Page 1 of 1

duplicated files in ZIP

Posted: Mon Sep 20, 2021 8:13 pm
by hector
Hello.

I was wondering how can this be. I always use the web interface and some ZIP files have duplicated files in them. I.e. the ZIP file contains 2 subtitle files with the same name. It is already weird that you can store 2 different files with the same name (path) in the ZIP. In the list they appear as "1 CD", of course.

For instance:
https://www.opensubtitles.org/en/subtit ... eolomea-de

How can this be? Could they be considered bad?

Re: duplicated files in ZIP

Posted: Wed Sep 22, 2021 10:47 am
by oss
hi,

I downloaded the ZIP: https://www.opensubtitles.org/en/subtit ... ub/8707922
$ md5 'eolomea.(1972).ger.1cd.(8707922).zip'
MD5 (eolomea.(1972).ger.1cd.(8707922).zip) = 497c36372d8aa691455e446937e789e1

$ unzip -l eolomea.\(1972\).ger.1cd.\(8707922\)
Archive: eolomea.(1972).ger.1cd.(8707922).zip
Length Date Time Name
--------- ---------- ----- ----
86270 09-22-2021 10:43 Eolomea (1972).srt
86212 09-22-2021 10:43 Eolomea (1972).srt
7018 09-22-2021 10:43 eolomea.(8707922).nfo
--------- -------
179500 3 files
you are right. we will look into this issue, we didnt know!

Re: duplicated files in ZIP

Posted: Wed Sep 22, 2021 10:54 am
by oss
https://www.opensubtitles.org/en/subtit ... eolomea-de

I see there are v4, and in header it shows just v3, so I assume the updating file didnt went through 100% OK, and also thats why there are 2 files in ZIP. I assume also this is very special case which doesnt happen often. For now I leave it as it is, if in future there will be more problems like this I can have a look.

Maybe updating with v5 would fix this - I am going to try.

So on edit screen it was offering 2 subtitles, then I checked DB and found the error. Now it should be ok I believe (or it will be ok, just in cache...)

Re: duplicated files in ZIP

Posted: Tue Nov 09, 2021 1:14 pm
by hector
Another one:
https://www.opensubtitles.org/en/subtit ... l-house-en
https://www.opensubtitles.org/en/subtit ... l-house-es

The question is what to do in these cases. Should I mark them as bad or what?

Re: duplicated files in ZIP

Posted: Tue Nov 09, 2021 3:33 pm
by oss
very strange indeed. In this case please try to rename subtitle filenames (using correct subtitles feature), so they will not have same name (CD1, CD2). After some time it should work.

Re: duplicated files in ZIP

Posted: Tue Nov 09, 2021 3:40 pm
by hector
No problem with me. I can rename those files while extracting. The quiestion, I insist, is whether we should report them as bad or not.

Re: duplicated files in ZIP

Posted: Tue Nov 09, 2021 5:15 pm
by oss
IF you rename subtitles, and then you are download subtitles as proper ZIP file and 2 files are in it, then I dont see reason to report it as wrong.

Re: duplicated files in ZIP

Posted: Thu Nov 11, 2021 5:57 pm
by hector
Because they are wrong. The two files in the ZIP have the same name, so you have to GUESS which of them is part 1 and which is part 2 and rename them properly.

Re: duplicated files in ZIP

Posted: Thu Nov 11, 2021 6:20 pm
by oss
thats true.