API return disabled subtitles

[johnbkk]

While using XBMC Subtitles addon, I started getting "Error while extracting". Decided to try to figure out the issue, so I ran the query manually using the XMLRPC Debugger.

I got the results I wanted, but one of the subtitle was disabled. So although full information was returned, it was impossible to download using ZipDownloadLink

The search query: True+Blood+S05E07
The problem subtitle:

Code: Select all

<name>SubDownloadLink</name>
<string>http://dl.opensubtitles.org/en/download/filead/1953171460.gz</string>

<name>ZipDownloadLink</name>
<string>http://dl.opensubtitles.org/en/download/subad/4623635</string>

<name>SubtitlesLink</name>
<string>http://www.opensubtitles.org/en/subtitles/4623635/true-blood-in-the-beginning-en</string>

Is there any reason to return disabled subtitles that we can't download?

I think it should either not be returned or a parameter indicating it's disabled should be there (I couldn't find one).

Another option would be to add a parameter to the search request to not return disabled subtitles. Searched this the forum and the API, but couldn't find any talk about the above. Hope I didn't miss anything

[oss]

Hi,

thanks for this error bug report, it is fixed, of course search should work only on available subtitles.