Problems with the addition of new lines in the srt files

[NomadaPT]

.... it seems the problem got fixed. The first line isn't replaced anymore. Tried it today....

Sorry, but I've also tried and the problem remains, when the subtitle have one line in or before the first second continues to be replaced by the ads.

I can't avoid questioning, it's really necessary? Right now non logged users already have pop-up windows, several ads and a re-direct window for download fully dedicated to the Open Subtitles MKV Player, and seems to be general consensus that this first line is annoying, highly undesirable and may result more in the withdrawal of users (translators/uploaders and downloaders) that in his attraction to the site, then why insist on it?

So far, all opinions expressed herein show that no one would care that the additions were made ​​at the end of the subtitles, so, if really necessary, why not put both lines there?

[eduo]

.... it seems the problem got fixed. The first line isn't replaced anymore. Tried it today....

Sorry, but I've also tried and the problem remains, when the subtitle have one line in or before the first second continues to be replaced by the ads.

I can't avoid questioning, it's really necessary? Right now non logged users already have pop-up windows, several ads and a re-direct window for download fully dedicated to the Open Subtitles MKV Player, and seems to be general consensus that this first line is annoying, highly undesirable and may result more in the withdrawal of users (translators/uploaders and downloaders) that in his attraction to the site, then why insist on it?

So far, all opinions expressed herein show that no one would care that the additions were made ​​at the end of the subtitles, so, if really necessary, why not put both lines there?

API users don't see the web at all, so they don't get any add or banner from it. The line may be aimed at those.

[arcchancellor]

As a Ubuntu user, I simply use gedit which is preinstalled and handles everything

me2. Simple but extensive.

For Windows, I used Editpad Lite (freeware).
http://www.editpadlite.com/
It's the best Notepad replacement I know.

Or Notepad++
http://en.wikipedia.org/wiki/Notepad%2B%2B
I used it under Windows few years ago and it leaves nothing to be desired.

[srtpal]

By the way, shouldn’t http://trac.opensubtitles.org/projects/opensubtitles be edited now? It still contains this line:

no signature or advertisment is added to subtitles

[oss]

done. for sure there are more outdated infos floating there.

[srtpal]

Thanks. :)

[subshare]

Hello, the problem still exists.

I just made another test. It seems to occur randomly.

Again, the first line was wiped and replaced with the opensubtitles ad-text.
Even though I was logged in! But no matter if I'm logged in or not. The first line should not be replaced!
It corrupts the subtitles. This really makes me angry. I hope it'll get fixed.

[oss]

problem is fixed, it was caused by utf-8 header, yeah, that utf-8 thing, preg_match, preg_replace doesnt like it with ^ operator....

For now 'top' ads stay there, I tried to remove it, but it is not so easy, as I thought.

[eduo]

problem is fixed, it was caused by utf-8 header, yeah, that utf-8 thing, preg_match, preg_replace doesnt like it with ^ operator....

For now 'top' ads stay there, I tried to remove it, but it is not so easy, as I thought.

mb_internal_encoding('UTF-8');

Or add (*UTF8) at the beginning of your pattern.

So, this wouldn't match:

Code: Select all

if (preg_match("/πhπ/i", "∏hπ is the web scripting language of choice.")) {
    echo "A match was found.";
} else {
    echo "A match was not found.";
}


But this would:

Code: Select all

if (preg_match("(*UTF8)/πhπ/i", "∏hπ is the web scripting language of choice.")) {
    echo "A match was found.";
} else {
    echo "A match was not found.";
}

Documented here: http://www.pcre.org/pcre.txt

[NomadaPT]

problem is fixed, it was caused by utf-8 header, yeah, that utf-8 thing, preg_match, preg_replace doesnt like it with ^ operator....

For now 'top' ads stay there, I tried to remove it, but it is not so easy, as I thought.

Thank you oss, I can confirm that, the first ads line isn't replacing the first subtitle line anymore.

However, I maintain my opinion (apparently shared by others) that this first line add is highly undesirable and should be removed or at least relocated to the end.

API users don't see the web at all, so they don't get any add or banner from it. The line may be aimed at those.

You are probably within reason. However, so far, I'm aware of two ways of downloading subtitles from Opensubtitles.org without being logged and without any ads, and there's probably more but I'm not searching. So, if the API users were the target of the ads let me say that this goal is partially a failure.

[eduo]

So, if the API users were the target of the ads let me say that this goal is partially a failure.

On the contrary. If the API users were the goal of the ads and 100% of API users are getting the ads then the goal is a complete success.

If the goal was to get 100% of web downloads with the ads then, I agree, the goal is failing. It should either cover all instances or none.

I'll get one further: If the user has donated to OpenSubtitles is the only time where ads may be unnecessary.

The other option, of course, is reconsidering ads at the front altogether. I used to hate them but agreed there're not many options to work within the confines of the already-limited SRT subtitle standard. I'm actually more annoyed at other teams credits, that appear with tons of tags and code and special characters in english subs (breaking the encoding, frequently) and I'm *really* annoyed at end-movie credits, because those tend to break dramatic endings, as you know that once that subtitle appears, there's nothing left said in the movie (and if the scene was dramatic, the subtitle breaks the mood).

What I'd do is have both subtitles, but subject to certain rules. For example not having the first subtitle appear if at least 4 seconds can't be found without any subs (using up 1.5 of those 4) and not having the last subtitle appear before at least 10 seconds after the last "proper" one.

Obviously, the biggest point of any ads is that they don't break the subtitles they're occupying so if they might, they shouldn't be included at all.

I'm completely against subtitles, by the way. When I worked subtitling movies and tv series in Mexico (as in "working for pay") I was always against putting the credits at the end for the "translator" and I still think the same. I have come to accept people's "need" of feeling acknowledged so I accept credits. And I have had to come to terms with the fact that subtitle sites will always insert their own credits (although it's irritating when there are either a lot of credits or when some are clearly stealing from the other, like when SUBTITULOS and Addic7ed both have a credit saying they did and synchr'd the sub or similar cases).

[srtpal]

I'm completely against subtitles, by the way.

I have a hard time believing that.

[eduo]

I'm completely against subtitles, by the way.

I have a hard time believing that.

Damn. I meant Subtitle credits

[subshare]

problem is fixed, it was caused by utf-8 header

UTF-8 header... so, that's why it occurred 'randomly'.

Thank you for the fix! Great job.